Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postPath configuration being ignored (close #1376) #1377

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

matus-tomlein
Copy link
Contributor

Issue #1376

In the v4 release, a bug was introduced that the postPath configuration option was ignored by the tracker – despite it being configured, the tracker is still using the default tp2 path.

This PR fixes the issue and makes sure to use the configuration option.

@matus-tomlein matus-tomlein requested review from agnessnowplow and greg-el and removed request for agnessnowplow November 11, 2024 14:44
Copy link

bundlemon bot commented Nov 11, 2024

BundleMon

Files added (6)
Status Path Size Limits
trackers/javascript-tracker/dist/sp.js
+24.44KB 30KB / +10%
libraries/browser-tracker-core/dist/index.mod
ule.js
+23.44KB 25KB / +10%
libraries/tracker-core/dist/index.module.js
+19.42KB 20KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+17.35KB 20KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+17.28KB 20KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.49KB 5KB / +10%

Total files change +105.41KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

@greg-el greg-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein matus-tomlein changed the base branch from master to release/4.0.2 November 11, 2024 15:18
@matus-tomlein matus-tomlein merged commit e6e853a into release/4.0.2 Nov 11, 2024
3 checks passed
@matus-tomlein matus-tomlein deleted the issue/fix_post_path branch November 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants